Feat/split extension package #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOU-amjs
requested changes
Sep 5, 2024
.npmrc
Outdated
| recursive-install = true | ||
| # 使用淘宝镜像源 | ||
| registry = https://registry.npmmirror.com |
There was a problem hiding this comment.
这个最好不用设置，到时我们配置github actions后是在github服务器上安装依赖的
package.json
Outdated
| "displayName": "Alova", | ||
| "description": "Generate and search APIs without API documentation any more", | ||
| "version": "0.0.10", | ||
| "description": "The devtools for alova.js", |
packages/wormhole/package.json
Outdated
| "author": "", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "@alova/templates": "workspace:^" |
There was a problem hiding this comment.
templates这个子包我感觉可以直接放在wormhole里面，因为它只会用在这一个地方，而不是通用的或需要发布的
packages/wormhole/package.json
Outdated
Comment on lines
6
to
7
| "main": "src/index.ts", | ||
| "module": "src/index.ts", |
| "name": "@alova/wormhole", | ||
| "version": "1.0.0", | ||
| "description": "generate api for alova.js", | ||
| "homepage": "https://alova.js.org", |
There was a problem hiding this comment.
还缺一个types指定这个包导出的函数对应的声明文件，这个声明文件一般是typings/index.d.ts（我现在都是这样做的，可以统一下）
packages/wormhole/src/index.ts
Outdated
| export * from './generate'; | ||
| export { default as Configuration } from './modules/Configuration'; | ||
| export * from './readConfig'; | ||
| export * from './type'; |
There was a problem hiding this comment.
type类型不需要在这里导出，指定package.json下的types字段就可以了
packages/wormhole/src/index.ts
Outdated
Comment on lines
1
to
7
| export * from './config'; | ||
| export * from './createConfig'; | ||
| export * from './functions/alovaJson'; | ||
| export * from './functions/openApi2Data'; | ||
| export * from './generate'; | ||
| export { default as Configuration } from './modules/Configuration'; | ||
| export * from './readConfig'; |
There was a problem hiding this comment.
- 这里不需要全部都对外暴露，我们只暴露几个预先说好的那几个函数就好了，其他的暴露后后面要改就比较麻烦了
- 对应的类型声明文件里也需要定义暴露的类型声明
同时优化了mergeObject方法，处理嵌套结构时，可以最大程度复用
Test/splited test vitest
JOU-amjs
force-pushed
the
feat/split-extension-package
branch
from
bfab345 to
ea7076d
Compare
…epo查找 我这边也基本测完了，这是我整理的几个优化点，然后就可以发布了。
Test/splited test vitest
…api files as generation sources
…vajs/devtools into test/splited-test-vitest
…vajs/devtools into feat/split-extension-package
…split-extension-package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.拆分wormhole包
2.拆出templates包
3.work改造